Add AACanonicaliseName setting to control redirection to the canonical ServerName #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, mod_ucam_webauth redirects clients to the canonical server hostname so that cookies end up set on that domain. That is not desirable behaviour on some environments, e.g. the SRCF where the ServerName (as set by the system administrator) might not match the user's preferred domain, and might cause the cookie to go missing if the website forces redirection to a non-canonical ServerAlias.
So, I've added a new configuration directive (AACanonicaliseName) to allow this behaviour to be overridden (either globally, in a block or in .htaccess). If "AACanonicaliseName off" is configured, mod_ucam_webauth will not explicitly redirect to the canonical name, and will let ap_construct_url determine what name to use when a full self-referential URL is needed (according to Apache's UseCanonicalName directive). I have not changed the default behaviour.
The SRCF has been running with an early version of this patch for many years without issue.